mehah / otclient

An alternative tibia client for otserv written in C++20 and Lua, made with a modular system that uses lua scripts for ingame interface and functionality, making otclient flexible and easy to customize
Other
263 stars 202 forks source link

One more drawing bug :) #137

Closed Klonoa88 closed 3 years ago

Klonoa88 commented 3 years ago

If you use borders itemid 8129, 8130, 8131, 8132, 8125, 8126, 8127, 8128 and more on tiles stonewall exemple itemid 5640, 5639, 5648, 5645, 5646 and more it does not draw in the correct order.

In game image Here Mapeditor image Here

Update: It's not just the red earth borders that draws wrong. It's all borders that have this Patterns Here

Hope you understand what I mean by my description; P

mehah commented 3 years ago

it's probably because the grounds are being grouped and when using "top ground" - "64x64" gives this problem, the advantage of grouping is that it increases performance, since I ask to draw the same ground only once, I can take that away, but there will be a decrease in performance, just to fix those edges that are between these types of ground, which is rare.

I can put a flag to enable/disable this.

Klonoa88 commented 3 years ago

I can put a flag to enable/disable this.

Yes do that :) Because it does not look good ingame as it does now

Klonoa88 commented 3 years ago

it's probably because the grounds are being grouped and when using "top ground" - "64x64" gives this problem, the advantage of grouping is that it increases performance, since I ask to draw the same ground only once, I can take that away, but there will be a decrease in performance, just to fix those edges that are between these types of ground, which is rare.

Where in the code is this piece so I can do some research myself?

mehah commented 3 years ago

Could you send me the part of this map and the location?

because I want to try to fix without putting a flag to disable and enable, if not possible, then I put and you test.

Klonoa88 commented 3 years ago

Here is that piece of the map. I have cut in 2 different examples where it goes wrong.

Download: Map.zip

This is what it looks like in the map editor Link This is what it looks like in game Link