Open tornadia opened 1 month ago
@tornadia build is broken.
@tornadia which has leading or trailing whitespace. This is now an error according to policy CMP0004.
@tornadia https://github.com/mehah/otclient/actions/runs/9700179052/job/26783002143?pr=781#step:8:371
Hi Mehah! I appreciate your thorough reviews to push this effort further and get it merged. I am planning to resolve the issue by removing the quotation marks and maybe separating the setters into different lines further if that doesn't work. In my local environment it is working fine. Can you suggest an approach to resolve this?
@tornadia From what I understand, these errors are syntax errors, I'll see if @dudantas or @beats-dh can help you.
Description
Fixes compiling on Ubuntu with disabled sound
Behavior
Actual
Doesnt compile if sound is used
Expected
Makes it possible to disable sound again
Fixes
# (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist