mehah / otclient

An alternative tibia client for otserv written in C++20 and Lua, made with a modular system that uses lua scripts for ingame interface and functionality, making otclient flexible and easy to customize
Other
242 stars 177 forks source link

build: use conditional sound libs for compiling on newer linux distros #781

Open tornadia opened 1 month ago

tornadia commented 1 month ago

Description

Fixes compiling on Ubuntu with disabled sound

Behavior

Actual

Doesnt compile if sound is used

Expected

Makes it possible to disable sound again

Fixes

# (issue)

Type of change

Please delete options that are not relevant.

How Has This Been Tested

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Test Configuration:

Checklist

mehah commented 1 month ago

@tornadia build is broken.

mehah commented 1 month ago

@tornadia which has leading or trailing whitespace. This is now an error according to policy CMP0004.

mehah commented 2 weeks ago

@tornadia https://github.com/mehah/otclient/actions/runs/9700179052/job/26783002143?pr=781#step:8:371

image

tornadia commented 2 weeks ago

@tornadia https://github.com/mehah/otclient/actions/runs/9700179052/job/26783002143?pr=781#step:8:371

Hi Mehah! I appreciate your thorough reviews to push this effort further and get it merged. I am planning to resolve the issue by removing the quotation marks and maybe separating the setters into different lines further if that doesn't work. In my local environment it is working fine. Can you suggest an approach to resolve this?

mehah commented 1 week ago

@tornadia From what I understand, these errors are syntax errors, I'll see if @dudantas or @beats-dh can help you.