mehah / otclient

An alternative tibia client for otserv written in C++20 and Lua, made with a modular system that uses lua scripts for ingame interface and functionality, making otclient flexible and easy to customize

Other

242 stars 177 forks source link

improve: replace type traits with STL #785

Closed ranisalt closed 2 weeks ago

ranisalt commented 1 month ago

Description

Since C++20 is enabled, these type traits are included in the standard library and don't need to be implemented here.

How Has This Been Tested

[ ] It compiles
[ ] Test B

Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I checked the PR checks reports
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works

ranisalt commented 1 month ago

Looks like Windows builds are broken, they're failing even on master

mehah commented 1 month ago

Looks like Windows builds are broken, they're failing even on master

we will analyze, but for now we can ignore this error and merge, just set this condition to not compile in MSVC. thx

mehah commented 2 weeks ago

@ranisalt Unfortunately, after these changes, the modules are showing errors. :S