search

mehah / otclient

An alternative tibia client for otserv written in C++20 and Lua, made with a modular system that uses lua scripts for ingame interface and functionality, making otclient flexible and easy to customize
Other
242 stars 177 forks source link

New Layout - Red Fist mode not working #794

Closed matheussf closed 1 week ago

matheussf commented 3 weeks ago

Priority

High

Area

What happened?

With the new changes on layout, the red fist mode is not working.

Not sure what is happening, since the code g_game.setPVPMode(pvpMode) is being reached with Red Fist enum set as 3 when the red fist mode button is enabled.

I've tried to look on the new layout PR what might be causing this, but there were so many commits and the commit that removes game_combatcontrols doesn't add this feature in the same commit, so information is lost between the commit history.

image

What OS are you seeing the problem on?

Windows

Code of Conduct

kokekanon commented 2 weeks ago

I tried to fix it, but my knowledge only goes up to 8.6. I don't know what PVP Mode is. in 8.6 is functional https://github.com/Nottinghster/otclient/pull/42

image I don't know why Nottinghster accepted it and then did revert xd

Nottinghster commented 2 weeks ago

If someone manage to implement/adapt the old combat controls in new layout, it will fix everything related to it

https://github.com/mehah/otclient/blob/dfcf9db6e4366e82cba2636bb85c51f79985ac3d/modules/game_combatcontrols/combatcontrols.lua

Nottinghster commented 2 weeks ago

@matheussf Could you take a look at this and fix it ?

matheussf commented 2 weeks ago

@matheussf Could you take a look at this and fix it ?

I'm working on the analyzers right now, and I feel that would take some time for me to fix it, have so much to learn yet. But I can try after the analyzers

Nottinghster commented 1 week ago

Fixed https://github.com/mehah/otclient/commit/c5c614154eb1197551455791168211023939028a