mehah / otclient

An alternative tibia client for otserv written in C++20 and Lua, made with a modular system that uses lua scripts for ingame interface and functionality, making otclient flexible and easy to customize
Other
267 stars 207 forks source link

Some bugs related to apparences.dat #875

Open dgprado-80 opened 2 months ago

dgprado-80 commented 2 months ago

Priority

Medium

Area

What happened?

Hireling Aprendice:

https://github.com/user-attachments/assets/9f68d756-49e7-424a-b097-16e4a412355d

https://github.com/user-attachments/assets/521c0aca-5a33-412b-9ec0-35843bbd1aec

https://github.com/user-attachments/assets/d157fd46-d452-4ba8-9842-c08c4a772ddd

What OS are you seeing the problem on?

Linux, Windows

Code of Conduct

dgprado-80 commented 2 months ago

There is some problems with some items too. If you have some items inside inbox store your character dont will log in. stamina estension and some furniture too. images of tier numbers are not shown WhatsApp Image 2024-09-13 at 14 58 25 WhatsApp Image 2024-09-13 at 14 58 26

kokekanon commented 2 months ago

thank you for reporting the error, so I can correct them, but your issues post are very badly structured and so is the title. video 1 solved IN PR 874 video 2 solved IN PR 874 video 3 solved IN PR 874 related to the store, which should be reported in issues you created earlier "buy button gamestore inactive even though you have enough coins in your account"

the pictures in your last comment I don't know what they are or what you want to indicate.

Real bug:

Error 1: "assets" in OTC:

/looktype 1108 cipsoft work redemption no work

40x30

Error 2: "gold pouch" in CANARY:

you can buy multiple "gold pouch" (using the otc terminal using lua you could send the opcode and purchase multiple, must be restricted from the server side)

image

Error 3: "packet error item -> house decoration." in OTC:

packet error in item house decoration. example this /i 23398

20:21:13 You see a decoration kit.
You bought this item in the Store.
Unwrap it in your own house to create a <alchemistic bookstand>.
Client ID: 23398
ERROR: ProtocolGame parse message exception (10374 bytes, 8965 unread, last opcode is 0x6e (110), prev opcode is 0xee (238)): InputMessage eof reached
Packet has been saved to packet.log, you can use it to find what was wrong. (Protocol: 1340)

related to GameWrapKit and https://github.com/mehah/otclient/blob/main/src/client/protocolgameparse.cpp#L3270

temp fix :

image or image

i don't know what this item is or what special attribute it has. i don't use canary

idk why that item is Clock Expire: false, Expire: false, Expire Stop: true <---

image