mehak24k / pe

0 stars 0 forks source link

No upper restrictions on digits of a phone number of a victim #1

Open mehak24k opened 3 years ago

mehak24k commented 3 years ago

When adding a victim, there is no upper limit on the digits the phone number of the victim can have. As shown below, it is possible to add a victim with a 27-digit phone number. Perhaps a reasonable limit can be set to prevent this from happening.

The input command was add victim n:Testname sex:m p:123456789123456789123456789 e:hello@email.com a:test address 1234. The expected behaviour would be reasonable error message to indicate that the phone number has too many digits.

Screenshot 2020-11-13 at 12.49.04 PM.png

nus-pe-bot commented 3 years ago

Team's Response

This is an inherited behaviour from AB3. However it can be considered for extensibility in the future, thank you!

image.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]


:question: Issue type

Team chose [type.FeatureFlaw] Originally [type.FunctionalityBug]

Reason for disagreement: [replace this with your explanation]