mehak24k / pe

0 stars 0 forks source link

Unsuitable error message for incorrect prefix used #3

Open mehak24k opened 3 years ago

mehak24k commented 3 years ago

When adding a victim, using an incorrect prefix results in an unsuitable error message.

As shown below, for the input command add victim n:name of victim sex:m p: 123456789 email:victim123@email.com a:Blk 123456789, an error message regarding the phone number is shown. However, the main source of the error is from an incorrect prefix used for the email field. The expected behaviour would be a more suitable error message for the user to use the correct prefix.

Screenshot 2020-11-13 at 12.59.39 PM.png

nus-pe-bot commented 3 years ago

Team's Response

for the command above, "email:" is not a valid prefix in our program. The behaviour of parsing inputs by prefix is inherited from AB3(shown below). Since "email:" has the wrong prefix, it was recognised as part of the input field for phone with prefix "p:". The error message returned is expected as the phone input has the wrong format.

image.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]