Closed Poikilos closed 6 months ago
Hey Poikilos! I have looked over the code and I have no issue approving and merging this. Thank you for implementing these features in CR. You might not see it get uploaded to SpigotMC until a later date. I need to get around to doing a few things -- such as:
https://github.com/mehboss/CustomRecipes/issues/43 https://github.com/mehboss/CustomRecipes/issues/39 https://github.com/mehboss/CustomRecipes/issues/31 https://github.com/mehboss/CustomRecipes/issues/24 https://github.com/mehboss/CustomRecipes/issues/42
And last but not least, the GUI.,, I may release an update prior to completing the GUI, however.
Thank you again!
Its up to you if you want this, but it works fine. Let me know if anything doesn't seem right. Some testing in older versions should probably be done as explained.
Converter: FURNACE
in recipe file (under main section) makes a Furnace recipe.Converter: STONECUTTER
in recipe file (under main section) makes a Stonecutter recipe.StonecutterRecipe
class in versions below 1.14 for backward compatibility, by using fully qualified name instead of importing it.Converter: STONECUTTER
is in a recipefile).Other changes:
serverVersionBelow
andserverVersionAtLeast
methods to make the code more clear and reliableserverVersionAtLeast
returns true anyway, andserverVersionBelow
returns false anyway (makes code try to run if version isn't detected, like the old code which only checked for "1_7" etc and disallowed those specific versions)r
togridRows
for clarity.Tested with only Paper 1.20.1 and 1.20.4, but built jar against AdvancedEnchantments-8.7.4.jar, latest BungeeCord.jar, PlaceholderAPI-2.11.5.jar, spigot-api-1.19.2-R0.1-20221106.071812-39.jar from URLs noted in requirements.md.