search

mehcode / atom-project-plus

Simply awesome project management in Atom.
https://atom.io/packages/project-plus
MIT License
99 stars 18 forks source link

Switching projects breaks find-and-replace:select-next #98

Open fredrikekelund opened 7 years ago

fredrikekelund commented 7 years ago

I've seen #95 and I've given project-manager a spin, but what I want is just a quick way of switching workspace, and manually handling projects in project-manager is tedious, so I came back to project-plus. I hope you haven't deprecated it completely just yet.

The issue at hand is the fact that every time I switch projects, the find-and-replace:select-next command increases the number of occurences it selects by 1. Example: if I have highlighted the word Section and click Cmd-d, then I expect only the next occurence of Section to be highlighted as well. But after having switched projects once, the next two occurences of Section are highlighted. After having switched projects twice, the next three occurences are highlighted. And so on...

McSodbrenner commented 7 years ago

The same for me. And the same reasons why I cannot switch.

btw: project-manager does have the same issue: https://github.com/danielbrodin/atom-project-manager/issues/339

fredrikekelund commented 7 years ago

Could these lines in atom-project-util be the culprit?

mehcode commented 7 years ago

I've seen #95 and I've given project-manager a spin, but what I want is just a quick way of switching workspace, and manually handling projects in project-manager is tedious, so I came back to project-plus. I hope you haven't deprecated it completely just yet.

Project Manager does support Git project detection though it's not implemented correctly (it detects at start of the editor and not when you open the project finder so it causes slowdowns in atom).

See https://github.com/danielbrodin/atom-project-manager/issues/345

@fredrikekelund Those lines could be it. I don't remember why they needed to be hacked before. Probably should have added that to the comment.

fredrikekelund commented 7 years ago

I'm not encountering this issues in Atom 1.19.0 anymore. Does it work for you as well, @McSodbrenner?

fredrikekelund commented 7 years ago

Scratch my last comment, it looks like the bug is still present 😞

xream commented 7 years ago

fixed by reload find-and-replace https://atom.io/packages/project-neue

aamederen commented 6 years ago

I have started to encounter this problem. I am using Atom 1.24.0 and project-plus 1.0.0.

jminuscula commented 6 years ago

I'm also experiencing this issue with Atom 1.26.0 and macOS 10.13.4

Find and Replace work on new windows, but as soon as I change projects, the dialog stops showing up. Reloading the window fixes it.

fredrikekelund commented 6 years ago

I'm experiencing the same issue as you @jminuscula. I've reported it in my previous issur https://github.com/atom/find-and-replace/issues/950. We'll see if someone picks it up, otherwise I'll open a new issue

jminuscula commented 6 years ago

@fredrikekelund looks like this project is abandoned in favor ofatom-project-manager. I've been using it for a few days without issues.