search

mehcode / config-rs

⚙️ Layered configuration system for Rust applications (with strong support for 12-factor applications).
Apache License 2.0
2.57k stars 213 forks source link

Format request: Dhall #123

Open passcod opened 4 years ago

passcod commented 4 years ago

The Dhall configuration language. Rust implementation.

let user = "bill"
in  { home       = "/home/${user}"
    , privateKey = "/home/${user}/.ssh/id_ed25519"
    , publicKey  = "/home/${user}/.ssh/id_ed25519.pub"
    }
matthiasbeyer commented 3 years ago

I'd love to review patches adding support for Dhall!

passcod commented 3 years ago

I'm actually not interested in Dhall as a useful configuration language anymore (happy to talk about this elsewhere) but will leave this open for others.

ChristopherRabotin commented 3 months ago

Hi there, I'm interested in this feature. Does it need a lot more work compared to @polarathene 's updated PR from last October or is that work essentially ready to merge?

Thanks

polarathene commented 3 months ago

updated PR from last October or is that work essentially ready to merge?

My PR should be fine with other ones I have open. I did a bit of refactoring for a more unified approach for serde based crates used and the Dhall PR should probably adapt to that.

My main PR for improving that was blocked by me on running some checks that I didn't get around to. I can try make time to come back to these, but the other issue you'd face is that this crate is no longer maintained AFAIK, not until some new maintainers are assigned / trusted.

ChristopherRabotin commented 3 months ago

Superb.

Yes, I'm aware that the Rust Dhall crate is no longer maintained. I'm just starting out with Dhall, and if it turns out to live to the hype I expect, then I may nominate myself to be the new maintainer. By chance, one of my friends is very knowledgeable in Dhall, and had been instrumental in finding work around to the handful of limitations of the Rust Dhall crate.

On Thu, Jun 6, 2024, 18:01 Brennan Kinney @.***> wrote:

updated PR from last October or is that work essentially ready to merge?

My PR should be fine with other ones I have open. I did a bit of refactoring for a more unified approach for serde based crates used and the Dhall PR should probably adapt to that.

My main PR for improving that was blocked by me on running some checks that I didn't get around to. I can try make time to come back to these, but the other issue you'd face is that this crate is no longer maintained AFAIK, not until some new maintainers are assigned / trusted.

— Reply to this email directly, view it on GitHub https://github.com/mehcode/config-rs/issues/123#issuecomment-2153599599, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABEZV2CKYHWC4A3F4SCFPXTZGDZ6DAVCNFSM6AAAAABI5NJGNKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNJTGU4TSNJZHE . You are receiving this because you commented.Message ID: @.***>

polarathene commented 3 months ago

I may nominate myself to be the new maintainer

Of Dhall? or config-rs? (related issue)

I can look at pushing my PRs forward here, but I'm not sure if a new release will be made until the maintainer situation is sorted out. I don't have the time to maintain anymore projects myself unfortunately 😓

If Dhall becomes maintained, it'd be easier to get my PR for that approved. I don't know what the future is for this crate, so if no new maintainer steps up for config-rs it may be better to push the support to another popular config crate?