search

mehcode / config-rs

⚙️ Layered configuration system for Rust applications (with strong support for 12-factor applications).
Apache License 2.0
2.43k stars 206 forks source link

Rethink #376

Open matthiasbeyer opened 1 year ago

matthiasbeyer commented 1 year ago

This is my "rethink" efforts.

As this effort is done to overthink the architecture of the whole codebase, it removes the old code entirely and replaces it with my re-think work.

I hope interested parties will have a look.

Relevant issues:

(maybe more will be added here)

Filed as draft, because this will be rebased as I see fit. So do not base any work on this except you want to add something to this PR!

FlixCoder commented 1 year ago

Do you think it would be possible to generate sample configs including doc comments with the new approach? Or would it still need a separate macro to get the doc comments?

I am thinking about writing a macro for generating sample configs with documentation of the fields.

matthiasbeyer commented 1 year ago

I could imagine that it would be possible.

milesj commented 1 year ago

Is there any progress on this? I'm looking to move away from figment, and this crate is probably the best choice, but based on all the refactor talk, I'm hesitant to move to it.

matthiasbeyer commented 1 year ago

Is there any progress on this?

There's progress here: https://github.com/matthiasbeyer/config-rs-ng - still slow, but at least there's progress!

I'm looking to move away from figment, and this crate is probably the best choice, but based on all the refactor talk, I'm hesitant to move to it.

The current config-rs version is still usable :laughing: - If we decide to move to the rewritten version, there will be a grace period and (if possible) compatible interfaces to make the move less complicated!

milesj commented 1 year ago

Thanks for the update, I'll keep an eye on it 👍