search

mehcode / config-rs

⚙️ Layered configuration system for Rust applications (with strong support for 12-factor applications).
Apache License 2.0
2.57k stars 213 forks source link

Add test with rust_decimal #415

Closed matthiasbeyer closed 1 year ago

matthiasbeyer commented 1 year ago

To test issue #414

matthiasbeyer commented 1 year ago

Why the hell does it not find rust_decimal? Locally this works perfectly nice and rust_decimal is in 1.27.0? :eyes:

matthiasbeyer commented 1 year ago

Issue was on users side, not gonna merge this to not unnecessarily bloat the dev-dependencies of the project.

telcy commented 1 year ago

According to rust_decimal docs: "The current minimum compiler version is 1.60.0 which was released on 2022-04-07."

That's why compiling for 1.59.0 failed.

matthiasbeyer commented 1 year ago

But wouldn't cargo still find the crate and try to compile it and then fail? From what I see, it fails to actually find the version!

telcy commented 1 year ago

I installed locally 1.59.0 and it failed with same output.

Probably just an early exit because of the rust version defined for the crate? https://github.com/paupino/rust-decimal/blob/bc8b53a7ca697945642ebe3a44f38d9cd6f0bd83/Cargo.toml#L19

https://doc.rust-lang.org/cargo/reference/manifest.html#the-rust-version-field

matthiasbeyer commented 1 year ago

Hm, okay. I didn't know cargo can do that. Thanks for investigating this!