search

mehcode / config-rs

⚙️ Layered configuration system for Rust applications (with strong support for 12-factor applications).
Apache License 2.0
2.43k stars 206 forks source link

Make the parse list key to lowercase when insert the keys #429

Closed bigduu closed 11 months ago

bigduu commented 1 year ago

428

matthiasbeyer commented 1 year ago

Hi, sorry for the slow response, I was on vacation.

The patch itself looks good. But I am slowly getting the impression that the whole env-parsing implementation was a mistake. It gets more and more complex.

Still, I give this a go for now.

matthiasbeyer commented 11 months ago

Care to make CI green here? :smiley:

bigduu commented 11 months ago

sorry，late reply，will let the CI green later: )

bigduu commented 11 months ago

The commit check detail is overdue, could you please approve the workflows?

matthiasbeyer commented 11 months ago

Done. The signoff is missing. Please rebase and signoff your commit (and remove the merge commit).

bigduu commented 11 months ago

Thanks, done

bigduu commented 11 months ago

do we have any updates? Please help to merge the PR, thanks

matthiasbeyer commented 11 months ago

Thanks for reminding me!

bigduu commented 11 months ago

Np,Thanks 😄