search

mehcode / config-rs

⚙️ Layered configuration system for Rust applications (with strong support for 12-factor applications).
Apache License 2.0
2.43k stars 206 forks source link

feat: Added Gura support #467

Open polarathene opened 9 months ago

polarathene commented 9 months ago

Rebased #446 with conflicts resolved. All credit to @mkvolkov for the actual contribution.

Added support for Gura.

Closes: #245

mkvolkov commented 9 months ago

@polarathene thanks, you can merge your PR

polarathene commented 9 months ago

I squashed some commits that were all related to review feedback, and revised commit titles prior to that, adding a sign-off to each.

Should be good for merging now 👍

polarathene commented 8 months ago

Since I don't know how long (or if) the Gura bug report will take to get a response and be resolved, I've raised another PR which further simplifies maintenance of this PR should it go stale for a while.

Ideally the only future change after review approval would be a version bump in Cargo.toml (even that may not be necessary for a bug fix release).

I'll update this PR to reflect that change (if the linked PR is rejected, the equivalent commit here can be reverted). I'll also address the weird 80 char commit message line length limit 🤔 (seems completely unnecessary in 2023 to limit to 80 chars). (Done)

Latest commit https://github.com/mehcode/config-rs/pull/467/commits/4140214c3fcd8e7c52838f81f4d8c3a487f50f17 depends on https://github.com/mehcode/config-rs/pull/472 to function. In the meantime https://github.com/mehcode/config-rs/pull/467/commits/0b781b8f9fc019a7ce990c9fcca8acb1aaf1d21c is usable if anyone wants to reproduce the test failure.

Genarito commented 8 months ago

gura-rs-parser issue was fixed! :partying_face:

vrurg commented 3 months ago

Turns out, another, now fixed, issue may be related to the failing tests.

Would it be possible to revive this PR?

polarathene commented 3 months ago

Would it be possible to revive this PR?

Yes, sorry I'm just stretched for time.

Trying to polish up a PR to Vector project atm, once I've reached that milestone, I'll switch over to config-rs PRs I have here 👍