search

mehcode / config-rs

⚙️ Layered configuration system for Rust applications (with strong support for 12-factor applications).
Apache License 2.0
2.43k stars 206 forks source link

Hide and deprecate AsyncConfigBuilder #480

Closed ijackson closed 8 months ago

ijackson commented 8 months ago

This seems to be a nonfunctional vestige.

matthiasbeyer commented 8 months ago

Your signoff is missing on the commits here, please add them.

Otherwise this is a good catch, thank you for contributing! :tada:

matthiasbeyer commented 8 months ago

gitlint will also complain here about long lines in the commit. Do you want me to take over to safe you the hassle?

ijackson commented 8 months ago

gitlint will also complain here about long lines in the commit. Do you want me to take over to safe you the hassle?

Does that mean I'm not to quote error messages in commit messages? That's a shame. Yes, please, do feel free to take this over.