search

mehcode / rn-splash-screen

A JavaScript-controlled splash-screen for React Native designed to be run directly after the native splash-screen.
MIT License
350 stars 95 forks source link

Update .npmignore #42

Closed vonovak closed 7 years ago

vonovak commented 7 years ago

I am not 100% sure with the slashes but I know for sure that you're distributing your example with the package

mehcode commented 7 years ago

Thanks for the adjustment. No need to clutter npm. I forget about .npmignore.

rmhartog commented 7 years ago

Would it be possible to publish a new version that doesnt contain the example project? Thanks!

vonovak commented 7 years ago

@mehcode yes, could you please make a release so I can stop using my fork? Thanks!

mehcode commented 7 years ago

Sure. Released as v4.0.1. I honestly didn't consider this to be that important. Would you satisfy my curiosity as to why this mattered to you? It's not like the example code gets bundled into your app.

vonovak commented 7 years ago

@mehcode I'm using MS mobile center for building the app and while I don't remember the exact reason, it was failing when the example was included. Thanks!

rmhartog commented 7 years ago

Did not have real failures but the example directory turns out to be quite big, we're trying to slim down our project in CI. Thanks!