Handling Android RN 0.47 breaking change

mehcode / rn-splash-screen

A JavaScript-controlled splash-screen for React Native designed to be run directly after the native splash-screen.

MIT License

350 stars 95 forks source link

Handling Android RN 0.47 breaking change #48

Closed bahaa96 closed 7 years ago

bahaa96 commented 7 years ago

facebook/react-native@ce6fb33

mehcode commented 7 years ago

Thanks @bahaa96

mehcode commented 7 years ago

@bahaa96 It actually looks like you deprecated the wrong method. createJSModules is the one that was removed, not createViewManagers. Could you fix that in another PR (and feel free to just delete the method instead of commenting out the @Overrides)?