search

mehdi-fathi / eloquent-filter

Eloquent Filter is a package for filter data of models by the query strings. Easy to use and fully dynamic.
https://mehdi-fathi.github.io/eloquent-filter/
MIT License
436 stars 42 forks source link

WhereBetweenCondition fails if start or end is zero #126

Closed elrasco closed 3 years ago

elrasco commented 3 years ago

Describe the bug In file eloquent-filter/src/QueryFilter/Detection/ConditionsDetect/WhereBetweenCondition.php the condition fails if start or end is zero

To Reproduce Steps to reproduce the behavior: Pass to method detect something like array ( 'price' => array ( 'start' => 0, 'end' => 336, ) )

Expected behavior detect returns WhereBetween::class

Actual behavior detect return null

mehdi-fathi commented 3 years ago

@elrasco Thanks for the report. I fixed it. Please update the package to 2.3.8.

elrasco commented 3 years ago

@mehdi-fathi thank you very much. It works now. super fast.