search

mehdi-fathi / eloquent-filter

Eloquent Filter is a package for filter data of models by the query strings. Easy to use and fully dynamic.
https://mehdi-fathi.github.io/eloquent-filter/
MIT License
436 stars 42 forks source link

Can't publish config #185

Closed ClProsser closed 2 years ago

ClProsser commented 2 years ago

Describe the bug According to the README.md the config can be published using:

php artisan vendor:publish --provider="eloquentFilter\QueryFilter\ServiceProvider"

However, this yields the error: No publishable resources for tag []. The reason is that the provider mentioned in the command does not match the definition. Laravel uses the function below to get the paths for publishing. Adding two dumps (one for $provider and one for static::$publishes) shows the missmatch. https://github.com/laravel/framework/blob/97b41840b9bbf93e0fe9c764201e77eb92a09dac/src/Illuminate/Support/ServiceProvider.php#L344

To fix is, simply update the command:

php artisan vendor:publish --provider="eloquentFilter\ServiceProvider"

To Reproduce Steps to reproduce the behavior:

  1. Install a fresh laravel instance
  2. Install this package (including app.php, ... according to instructions)
  3. Publish the config using the command mentioned above.

Expected behavior The config should be published (without the error message)

Screenshots

The missmatch mentioned above (using two dumps): WindowsTerminal_sl32FUL8U6