Support for Laravel 11?

mehdi-fathi / eloquent-filter

Eloquent Filter is a package for filter data of models by the query strings. Easy to use and fully dynamic.

https://mehdi-fathi.github.io/eloquent-filter/

MIT License

430 stars 43 forks source link

Support for Laravel 11? #210

Closed arislanhaikal closed 2 months ago

arislanhaikal commented 4 months ago

Please add support for Laravel 11. And how i can config it?

Thank you

mehdi-fathi commented 4 months ago

@arislanhaikal

Since Laravel 11 was released freshly, It seems some dependency packages are not working with the process of testing the eloquent filter. We need to wait until we find a better opportunity to support that.

arislanhaikal commented 4 months ago

Oh, i'm sorry to hear that. Hopefully find the best solution, because your filter package really helped me 🙏🏻

mehdi-fathi commented 4 months ago

@arislanhaikal

Supporting Laravel 11 has been solved so you can update to 4.2.0 version.

arislanhaikal commented 4 months ago

Hi @mehdi-fathi thank you for fast working it

But i have some issue,

With step

Iam already instal version 4.2.0 & registered in service provider
make php artisan eloquentFilter:filter UserFilter
add trait in user model Filterable, UserFilter
in UserFilter, I make name query search with function name
in Controller, I add User::filter()->
i tested but not working with error
You must set name in whiteListFilter in User or create an override method with name name or call ignoreRequest method for ignore name.

I dont know this is issue or not, but in old version its just work fine! Please explain whether there are any steps missed!

Thank you

mehdi-fathi commented 4 months ago

@arislanhaikal You need to change the method to filterCustomName. I'll fix the artisan command soon.

MLDMoritz commented 2 months ago

@arislanhaikal You need to change the method to filterCustomName. I'll fix the artisan command soon.

I came along this issue today, it took a bit research to fix this.