Closed Alan-MQ closed 1 year ago
Hi, Thanks for your contribution.
There is a CI/Build error in the GitHub action pipeline, maybe the reason is removing google.golang.org/genproto
and mergo
pkg (for now I suggest don't touch the packages, for refactoring pkg and removing useless pkg it's better a separated pull request). Revert this change in all go.mod file and the check for passing CI/Build
Hi, Thanks for your contribution. There is a CI/Build error in the GitHub action pipeline, maybe the reason is removing
google.golang.org/genproto
andmergo
pkg (for now I suggest don't touch the packages, for refactoring pkg and removing useless pkg it's better a separated pull request). Revert this change in all go.mod file and the check for passing CI/Build
ok I will do that.
Hi, Thanks for your contribution. There is a CI/Build error in the GitHub action pipeline, maybe the reason is removing
google.golang.org/genproto
andmergo
pkg (for now I suggest don't touch the packages, for refactoring pkg and removing useless pkg it's better a separated pull request). Revert this change in all go.mod file and the check for passing CI/Buildok I will do that.
thanks :) Also, please update your fork branch, with upstream branch because, there is a small change in the go.mod file in pkg module.
Hi, Thanks for your contribution. There is a CI/Build error in the GitHub action pipeline, maybe the reason is removing
google.golang.org/genproto
andmergo
pkg (for now I suggest don't touch the packages, for refactoring pkg and removing useless pkg it's better a separated pull request). Revert this change in all go.mod file and the check for passing CI/Buildok I will do that.
thanks :) Also, please update your fork branch, with upstream branch because, there is a small change in the go.mod file in pkg module.
ok, I will revert them and try to make it work, but I can't trigger CI process, should I create a new workflow on my forked project?
I changed permissions for showing github action status for others, for your next change you should see the pipeline status here, for now there is an error in the unit test
I changed permissions for showing github action status for others, for your next change you should see the pipeline status here, for now there is an error in the unit test
ok sure, I will manage to pass that unit test(good one), so every time I commit will trigger the ci right?
I changed permissions for showing github action status for others, for your next change you should see the pipeline status here, for now there is an error in the unit test
ok sure, I will manage to pass that unit test(good one), so every time I commit will trigger the ci right?
Yes, after each push the CI pipeline will trigger, and you can check its result. I recommend running unit tests locally with a make file that I prepared locally. For example, in root of project just type make unit-test
after installing make in your OS, and it will run all unit-tests locally
thank you I will try that make unit-test.
Please also update README file, for adding ozz
Please also update README file, for adding ozz
yeah, I will add that after I fix that linting stuff.(I did't see any one pass that linting action, so I guess that's not a problem? but I set my my goland gofumpt locally)
my labeler action keep failing, does it matter? seems like some kind httpResource is not accessbile~~
my labeler action keep failing, does it matter? seems like some kind httpResource is not accessbile~~
Yes, Labler action
has some bug, Also my linting action
is very strict I should make it simpler, no problem for you.
Thanks for this pull request, and this enhancement, I appreciate about that :) Just one note after resolving my review, please resolve that review with resolve button, it will look better 👍🏻
Thanks for this pull request, and this enhancement, I appreciate about that :) Just one note after resolving my review, please resolve that review with resolve button, it will look better 👍🏻
yeah, I didn't know github have that function~~
I made some changes on the catlog_write_log_service and If you think it's the right way to do that I will then do the rest btw there is some changes on the go.mod file(not the new module) please check that too~~ thank you for your time.