search

mehdime / DbContextScope

A simple and flexible way to manage your Entity Framework DbContext instances
http://mehdi.me/ambient-dbcontext-in-ef6/
MIT License
631 stars 273 forks source link

signing assembly #23

Closed maldworth closed 9 years ago

maldworth commented 9 years ago

Hey @tiesont and @mehdime, I'd like to sign the assembly because I'm prevented from using it in one of my projects because it's not strongly named. We obviously don't want to commit a private signature key to the repo. If you guys will sign the assembly then that's great otherwise can you give me access in Nuget and I can sign the latest one then Share the signing key among us (through email, dropbox, drive, or however we agree to share the key).

Thanks

tiesont commented 9 years ago

@mehdime is the project owner, so this is just my opinion, but I don't think signing the assembly provides any real benefit.

You can always fork the repo and sign your own copy. Otherwise, I'd recommend creating another package, with perhaps a similar name, like Mehdime.Entity.Signed. That would allow anyone who wants to use the library to decide if they want the signed version or not. On Aug 12, 2015 10:54 AM, "maldworth" notifications@github.com wrote:

Hey @tiesont https://github.com/tiesont and @mehdime https://github.com/mehdime, I'd like to sign the assembly because I'm prevented from using it in one of my projects because it's not strongly named. We obviously don't want to commit a private signature key to the repo. If you guys will sign the assembly then that's great otherwise can you give me access in Nuget and I can sign the latest one then Share the signing key among us (through email, dropbox, drive, or however we agree to share the key).

Thanks

— Reply to this email directly or view it on GitHub https://github.com/mehdime/DbContextScope/issues/23.

maldworth commented 9 years ago

@tiesont yeah, no reason to discuss the merits for signed or unsigned DLL of an open source project, but I like your idea for me to fork and then I'll create a Nuget.org project named Mehdime.Entity.Signed. I looked in your fork for a .Nuspec file that you used to make it but I couldn't find one. I can generate one from the proj but I would like to keep it consistent with the unsigned package you made. Could you gisthub it or send it to me perhaps? Thanks!

tiesont commented 9 years ago

@maldworth There currently isn't a .nuspec file, as I normally just use the Package Explorer to build the package manually. I'll see if I can find a few minutes to generate one and do a pull request.

tiesont commented 9 years ago

@maldworth This is the nuspec file the current package uses: https://gist.github.com/tiesont/8929a952be112f9cc7e3 - I don't think I'll have time to add one to the build process anytime soon, so that's the best I can do.

maldworth commented 9 years ago

great thanks @tiesont !