search

mehdisadeghi / react-mathjax-preview

The MathJax React component you were looking for.
https://mehdisadeghi.github.io/react-mathjax-preview/
MIT License
49 stars 30 forks source link

Fix potential IDs duplicates #49

Closed MikeSha closed 4 years ago

MikeSha commented 4 years ago

Also now it is possible to set id through props

Not sure I understand why tests are failing

mehdisadeghi commented 4 years ago

Thanks for the PR. Would you mind though explaining which problem are we solving here?

MikeSha commented 4 years ago

Sure. I have a complex object of MathJax data, and I need to parse it recursively. It doesn’t mater actually, but the thing is I need unique ID for each item in the DOM.

вт, 23 черв. 2020 о 22:40 Mehdi Sadeghi notifications@github.com пише:

Thanks for the PR. Would you mind though explaining which problem are we solving here?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mehdisadeghi/react-mathjax-preview/pull/49#issuecomment-648377147, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABIN4DJ3QLSYBACC5PFHCYDRYEAJDANCNFSM4OERWNMA .

mehdisadeghi commented 4 years ago

Fair enough. Just add a default id and we are good to go.

MikeSha commented 4 years ago

Fair enough. Just add a default id and we are good to go.

Done! Thank you!

mehdisadeghi commented 4 years ago

@MikeSha I think you've some syntax error or alike. btw, I fixed that initial build issue in master, so if you update your branch it should built correctly.

MikeSha commented 4 years ago

Finally done :) @mehdisadeghi

mehdisadeghi commented 4 years ago

@MikeSha see v2.0.2