search

mehdy / keepalived-exporter

Prometheus Keepalived exporter
GNU General Public License v3.0
124 stars 39 forks source link

fix: send signal for before getting script #138

Closed mehdy closed 1 year ago

mehdy commented 1 year ago

Fixes #135

mehdy commented 1 year ago

Yeah, I noticed. It's a bad idea that we rely on the order of execution. Each function should be able to respond correctly on its own.

clwluvw commented 1 year ago

Yeah, I noticed. It's a bad idea that we rely on the order of execution. Each function should be able to respond correctly on its own.

I guess we already tried to do that but the fact is the ScriptVrrps is relying on DataVrrps functionality - maybe it would make sense to mix ScriptVrrps and DataVrrps into a single func? But still extracting the signal would make more sense I guess :))

mehdy commented 1 year ago

Yes. I think this could be a better impl for now. Let me know what you think.