search

mehdy / keepalived-exporter

Prometheus Keepalived exporter
GNU General Public License v3.0
115 stars 37 forks source link

feat: Support custom waiting time for keepalived to create files #85

Closed mingqing closed 1 year ago

mingqing commented 1 year ago

Signed-off-by: mingqing limingqing@cyou-inc.com

to fix: #75

mehdy commented 1 year ago

@mingqing Thanks for opening the PR and I'm sorry for the long delay. I think it wouldn't be a good idea to create a custom wait-time option to handle this issue. Instead, I suggest a fixed waiting time (e.g. 6s). It would be much better to check for the files' existence and wait for 1s and check again, then 2s and then 3. (A total of 6s).

Please let me know if you'd like to make the changes.

mingqing commented 1 year ago

@mehdy I tried to check if the file is generated and set the max waiting time to 6s as a timeout (or others fix time), then compare and resubmit the PR.

mehdy commented 1 year ago

@mingqing Hi there, Didn't you want to do this feature?

mingqing commented 1 year ago

@mehdy I testing new code. sync the latest code on github when resolving conflicts it closed the this PR, i will retry open it.