search

mehdy / keepalived-exporter

Prometheus Keepalived exporter
GNU General Public License v3.0
115 stars 37 forks source link

fix: drop state label from metrics #97

Closed clwluvw closed 1 year ago

clwluvw commented 1 year ago

As the vrrp state would change from time to time, having it as a label will lead to introducing new metrics which isn't a good practice. It will also make duplicated metrics in grafana dashboard view which is unnecessary.

Signed-off-by: Seena Fallah seenafallah@gmail.com

mehdy commented 1 year ago

Makes sense. But don't we need to expose the state in some other way?

clwluvw commented 1 year ago

Makes sense. But don't we need to expose the state in some other way?

It's already being exposed through the keepalived_vrrp_state metric for each VIP and VRRP Instance.