mehrancodes / laravel-harbor

a cli tool to Quickly create on-demand preview environment for your app on Laravel Forge.
https://www.laravel-harbor.com
MIT License
75 stars 7 forks source link

Error after update to v0.1.1 #49

Closed webard closed 11 months ago

webard commented 11 months ago

Hello,

after updating veyoze to v0.1.1 there is error during deployment:

  FAIL    ---> The git token field must be a string.
  FAIL    ---> The git issue number field must be a string.

   Laravel\Forge\Exceptions\ValidationException 

  The given data failed to pass validation.

  at /composer/vendor/illuminate/support/helpers.php:330
    326▕     function throw_if($condition, $exception = 'RuntimeException', ...$parameters)
    327▕     {
    328▕         if ($condition) {
    329▕             if (is_string($exception) && class_exists($exception)) {
  ➜ 330▕                 $exception = new $exception(...$parameters);
    331▕             }
    332▕ 
    333▕             throw is_string($exception) ? new RuntimeException($exception) : $exception;
    334▕         }

On version v0.1.0 everything works fine.

webard commented 11 months ago

I think it is related to new feature: posting URL to Pull Request, but I did not enabled this.

mehrancodes commented 11 months ago

Thanks for letting me know! I'll fix it now 👨🏻‍💻 It should not require git token when it is disabled

mehrancodes commented 11 months ago

https://github.com/mehrancodes/veyoze/releases/tag/v0.1.2

@webard Got it fixed :) Would be happy to help if there is any issue left yet.