search

mehrancodes / laravel-harbor

a cli tool to Quickly create on-demand preview environment for your app on Laravel Forge.
https://www.laravel-harbor.com
MIT License
75 stars 7 forks source link

Pull Request Deployment #51

Closed webard closed 10 months ago

webard commented 11 months ago

Hello,

When using veyoze (my CI is named "Deploy provision", i think "deploy" word in name cause this), in my project's Pull Request show information

image

Is there any chance to put information about deployment (probably preview link) to this section, instead of pull request comment?

Unfortunately I didn't found a way to do this, only some informations: https://sanderknape.com/2020/05/deploy-pull-requests-github-actions-deployments/

mehrancodes commented 11 months ago

I like this idea! Definitely gonna try it this weekend.

mehrancodes commented 10 months ago

@webard I gave a try to the GitHub deployment api last weekend here https://github.com/mehrancodes/veyoze-laravel-sample/pull/6

I have submitted a PR for this recently, which creates a deployment when Veyoze starts provisioning. Once provisioning has been completed, the environment URL will be added.

Already trying to clarify if it would be a good replacement for the PR comments before we do the release 👨🏻‍💻

mehrancodes commented 10 months ago

It has been a while since I tried GitHub Deployments, and while it gives us a nice way to get the environment URL, I discovered that I am unable to add any extra information such as the database URL (which I have added recently to the PR comments feature).

In the future, we hope to improve the PR comments even more, so QA engineers have access to a variety of links all in one place.

In any case, thank you for your recommendation and please do not hesitate to contact us again whenever you have another idea in mind.