search

mehrancodes / laravel-harbor

a cli tool to Quickly create on-demand preview environment for your app on Laravel Forge.
https://www.laravel-harbor.com
MIT License
75 stars 7 forks source link

Comment not including the correct environment URL #72

Closed gbradley closed 6 months ago

gbradley commented 7 months ago

A recent site resulted in the following GitHub comment being created:

Screenshot 2024-02-27 at 17 45 48

It appears the "Environment Url" $name property from the EnvironmentUrlBuilder is being passed in ratehr than the actual url? I haven't had time to dig into the code yet but will submit a PR if I can identify the problem.

mehrancodes commented 7 months ago

This is interesting. The environment url's value comes from the (Forge site name)[https://forge.laravel.com/api-documentation#get-site] which is expected to be a domain name.

By any chance, does it still happening for you? As it works correctly for me already.

mehrancodes commented 7 months ago

Today I noticed an inconsistency with the database URL name on the PR comment. Currently, it's set as "DatabaseBuilder Url" instead of "Database Url," which is incorrect.

Screenshot 2024-03-05 at 18 21 20
mehrancodes commented 6 months ago

Fixed the DatabaseBuilder Url name.

I'm closing this issue since the Environment Url looks right. Feel free to comment or open a new issue if it's still wrong.

gbradley commented 6 months ago

Hi, yes I’ve never had this happen again, very odd. The only issue I’ve noticed is the URL seems to use http:// even when SSL has been enabled, but I haven’t checked that recently so may open a separate issue.