search

mehrnoushmalek / flowDensity

Automated gating
7 stars 3 forks source link

Transition away from rgeos dependency? #6

Open FMKerckhof opened 3 years ago

FMKerckhof commented 3 years ago

Dear,

I was wondering how flowDensity will deal with the "retirement" of rgeos by 2023 (see https://cran.r-project.org/web/packages/rgeos/index.html) - is there a plan to change the imports gIntersects, gDifference and gBuffer to different dependencies?

mehrnoushmalek commented 3 years ago

Hi @FMKerckhof, Haven't thought about it yet but will need to change these at some point ( probably by early next year though). Is there any concern?

FMKerckhof commented 3 years ago

Hi @mehrnoushmalek : I am making the transition from flowAI towards flowCut which is dependent upon flowDensity - one of the factors that I am trying to consider is the reliance upon dependencies. I already made a fork to experiment with sf::st_intersect, sf::st_difference and sf::st_buffer but it appears the sf implementation has a few idiosyncrasies that I need to get a better feel of (they are not drop-in replacements for rgeos). I'll keep you posted if I get it working and maybe send out a PR then.

mehrnoushmalek commented 3 years ago

@FMKerckhof That's right, but I think flowCut uses deGate from flowDensity, and you can technically import that to ignore rgeos. But let me know if you find a way, and I'll see if there are other packages that do what I need from rgeos.