mehta-lab / multiSero

serological measurements from multiplexed ELISA assays
BSD 3-Clause "New" or "Revised" License
6 stars 3 forks source link

Registration class #75

Closed jennyfolkesson closed 4 years ago

jennyfolkesson commented 4 years ago

I turned the grid registration functions into a class for improved ease of use and readability.

codecov-commenter commented 4 years ago

Codecov Report

Merging #75 into master will decrease coverage by 10.72%. The diff coverage is 90.83%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #75       +/-   ##
===========================================
- Coverage   55.81%   45.09%   -10.73%     
===========================================
  Files          26       18        -8     
  Lines        2105     1590      -515     
===========================================
- Hits         1175      717      -458     
+ Misses        930      873       -57     
Flag Coverage Δ
#unittests 45.09% <90.83%> (-10.73%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
array_analyzer/workflows/registration_workflow.py 20.68% <0.00%> (+1.54%) :arrow_up:
array_analyzer/transform/array_generation.py 16.07% <20.00%> (ø)
array_analyzer/transform/point_registration.py 78.67% <99.04%> (+53.91%) :arrow_up:
array_analyzer/extract/constants.py 100.00% <100.00%> (ø)
array_analyzer/utils/io_utils.py 90.27% <100.00%> (+0.13%) :arrow_up:
tests/utils/io_utils_test.py
tests/utils/spot_regionprop_test.py
tests/extract/test_metadata.py
tests/pysero_test.py
tests/test_debug_plots.py
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3b92c57...d5eb0dc. Read the comment docs.

jennyfolkesson commented 4 years ago

FYI: codcov check failed because coverage has gone down compared to master, but that's only because I removed the tests directory from being counted as covered code.