jennyfolkesson
commented
3 years ago Cool, thanks. I'll take a look tonight!
On Wed, Sep 1, 2021, 17:38 smguo @.***> wrote:
This PR increases the number of outlier fiducial spots allowed in grid registration up to 3 when n(fiducial)=5, which was constrained to be 1. This is necessary to get the OD from images where some fiducials are not detected in @lenafb https://github.com/lenafb 's recent data.
@jennyfolkesson https://github.com/jennyfolkesson I submitted an IT request to add you to Biohub Github so I can add you as a reviewer too.
You can view, comment on, or merge this pull request online at:
https://github.com/czbiohub/pysero/pull/83 Commit Summary
- fix bug about nbr_outliers
- relax nbr_outliers constraint
File Changes
- M array_analyzer/transform/point_registration.py https://github.com/czbiohub/pysero/pull/83/files#diff-8639715c1035823fc936d119b62a2b6064cea92961037ad04862999047aa8a6e (7)
Patch Links:
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/czbiohub/pysero/pull/83, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABT3MZOLCB7XHNRQBQLFAS3T73BPHANCNFSM5DHXHMYA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
This PR increases the number of outlier fiducial spots allowed in grid registration up to 3 when n(fiducial)=5, which was constrained to be 1. This is necessary to get the OD from images where some fiducials are not detected in @lenafb 's recent data.
@jennyfolkesson I submitted an IT request to add you to Biohub Github so I can add you as a reviewer too.