search

mehta-lab / multiSero

serological measurements from multiplexed ELISA assays
BSD 3-Clause "New" or "Revised" License
6 stars 3 forks source link

Multisero refactor #91

Closed lenafb closed 2 years ago

lenafb commented 3 years ago

I have refactored the multiSero codebase such that README, documentation, module names, and command line all reflect the name change from pysero to multiSero. I am suggesting this merge for naming consistency moving forward.

lenafb commented 3 years ago

Note: first commit "pysero refactor part i" incorporates heatmap plotting functions from heatmap-plotting branch that existed in my local pysero repo

codecov-commenter commented 2 years ago

Codecov Report

Merging #91 (ea0be0b) into master (aef0d98) will decrease coverage by 1.04%. The diff coverage is 21.05%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #91      +/-   ##
==========================================
- Coverage   37.03%   35.99%   -1.05%     
==========================================
  Files          21       21              
  Lines        2114     2192      +78     
==========================================
+ Hits          783      789       +6     
- Misses       1331     1403      +72
Flag Coverage Δ
unittests 35.99% <21.05%> (-1.05%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
array_analyzer/workflows/registration_workflow.py 21.17% <0.00%> (+1.17%) :arrow_up:
array_analyzer/workflows/well_wf.py 22.41% <ø> (ø)
interpretation/od_analyzer.py 15.88% <8.33%> (-0.15%) :arrow_down:
interpretation/report_reader.py 9.50% <8.69%> (ø)
interpretation/plotting.py 10.56% <15.38%> (-1.21%) :arrow_down:
multisero.py 78.68% <50.00%> (ø)
array_analyzer/extract/constants.py 100.00% <100.00%> (ø)
array_analyzer/extract/img_processing.py 13.63% <100.00%> (ø)
array_analyzer/extract/metadata.py 83.89% <100.00%> (ø)
array_analyzer/transform/array_generation.py 16.07% <100.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update aef0d98...ea0be0b. Read the comment docs.

lenafb commented 2 years ago

Hi @smguo, I've pushed commits addressing your previous comments, I think that this version is a little easier to parse and debug should a user need to tweak parameters.