search

mehta-lab / recOrder

3D quantitative label-free imaging with phase and polarization
BSD 3-Clause "New" or "Revised" License
12 stars 4 forks source link

Remove assertion and unused function #385

Closed ziw-liu closed 1 year ago

ziw-liu commented 1 year ago

Fix #213.

Also remove the orphaned get_unimodal_threshold function. This was likely used for segmentation (e.g. finding nuclei mask) and is now part of other analysis pipelines. We can also add a deprecation warning instead of removal for 0.4.0 if anyone is potentially still using it from here.

talonchandler commented 1 year ago

Thanks!

I looked into the history of get_unimodal_threshold, and it seems to be related to some unfinished background subtraction features for fluorescence.

If we want to use this code, I think it's best for it to live outside of recOrder so I'm approving.