Closed talonchandler closed 10 months ago
Merging #426 (7bd38b7) into main (bbf3502) will decrease coverage by
0.08%
. The diff coverage is0.00%
.:exclamation: Current head 7bd38b7 differs from pull request most recent head e96576f. Consider uploading reports for the commit e96576f to get more accurate results
@@ Coverage Diff @@
## main #426 +/- ##
========================================
- Coverage 8.66% 8.58% -0.08%
========================================
Files 26 26
Lines 4443 4484 +41
========================================
Hits 385 385
- Misses 4058 4099 +41
Files Changed | Coverage Δ | |
---|---|---|
recOrder/acq/acquisition_workers.py | 0.00% <0.00%> (ø) |
|
recOrder/calib/calibration_workers.py | 0.00% <0.00%> (ø) |
|
recOrder/io/utils.py | 0.00% <0.00%> (ø) |
|
recOrder/plugin/gui.py | 0.00% <0.00%> (ø) |
|
recOrder/plugin/main_widget.py | 0.00% <0.00%> (ø) |
Preview page for your plugin is ready here: https://preview.napari-hub.org/mehta-lab/recOrder/426 Updated: 2023-08-24T18:46:05.919001
Thanks for your help here @ziw-liu!
This PR makes the following improvements to the birefringence overlays:
The demo gif below demonstrates the main features. Even though I'm only showing a small region, the overlay is being computed for a 2048 x 2048 FOV---the largest we typically use. I estimate the lag time to be 0.1-0.2 seconds, which is noticeable but worth it IMO. You can also "hide" the layer to stop the lazy computation. @ziw-liu and I have discussed plans for 1.0.0 that will allow these computations to happen on a separate thread.
Thanks @ziw-liu for your help with this.