Direct link to README image

mehta-lab / recOrder

3D quantitative label-free imaging with phase and polarization

BSD 3-Clause "New" or "Revised" License

11 stars 4 forks source link

Direct link to README image #447

Closed talonchandler closed 9 months ago

talonchandler commented 9 months ago

Here is the 0.4.1rc0 release page: https://pypi.org/project/recOrder-napari/0.4.1rc0/

I don't expect the videos to appear on PyPI since they're hosted on github (the links will download them correctly).

This PR is an attempt to get the youtube thumbnail to appear correctly on the PyPI release page.

talonchandler commented 9 months ago

TBH I'm not sure if this fix will work. My vscode markdown viewer doesn't resolve the link correctly:

I'm not too concerned since traffic to the PyPI release page isn't huge, but I'm open to ideas.

codecov[bot] commented 9 months ago

Codecov Report

Merging #447 (c126037) into main (7f33e5d) will not change coverage. The diff coverage is n/a.

:exclamation: Current head c126037 differs from pull request most recent head 33e5d8d. Consider uploading reports for the commit 33e5d8d to get more accurate results

@@          Coverage Diff          @@
##            main    #447   +/-   ##
=====================================
  Coverage   8.83%   8.83%           
=====================================
  Files         29      29           
  Lines       4561    4561           
=====================================
  Hits         403     403           
  Misses      4158    4158

ziw-liu commented 9 months ago

With https://github.com/mehta-lab/recOrder/pull/447/commits/33e5d8d925463d62958c27f4b19d9f4daa889794 it shows up in the preview.