search

mehta-lab / recOrder

3D quantitative label-free imaging with phase and polarization
BSD 3-Clause "New" or "Revised" License
12 stars 4 forks source link

Optional GUI/PM dependencies #456

Closed ziw-liu closed 11 months ago

ziw-liu commented 11 months ago

In PhenoSight and mantis, the pinned Qt and pycro-manager versions makes depending on recOrder difficult.

Here these dependencies are made optional through the acq flag.

codecov[bot] commented 11 months ago

Codecov Report

Merging #456 (6016e6a) into main (5becc0c) will not change coverage. The diff coverage is 0.00%.

@@          Coverage Diff          @@
##            main    #456   +/-   ##
=====================================
  Coverage   9.45%   9.45%           
=====================================
  Files         29      29           
  Lines       4592    4592           
=====================================
  Hits         434     434           
  Misses      4158    4158
Files Coverage Δ
recOrder/plugin/__init__.py 0.00% <0.00%> (ø)
mattersoflight commented 11 months ago

@talonchandler @ieivanov @ziw-liu Since we are now preparing recOrder for use as image analysis library in other projects (mantis, phenosight), it makes sense that napari and pycro-manager are optional dependencies.

Please review and merge soon. @ziw-liu I suggest that phenosight fetches recOrder from git repo instead of pypi while we fine tune recOrder to work well with it.

cc: @Soorya19Pradeep