mehta-lab / recOrder

3D quantitative label-free imaging with phase and polarization
BSD 3-Clause "New" or "Revised" License
12 stars 4 forks source link

Visualizing full volume in recOrder GUI display #84

Open JohannaRahm opened 2 years ago

JohannaRahm commented 2 years ago

Hi, I ran into an unexpected behavior when visualizing the retardance orientation overlay for the full volume with recOrder GUI --> Display. Checking the box "use full volume" only applies the overlay to one z-slice, whereas defining a fixed position applies the overlay to all layers, allowing to scroll through them with the slider.

Setting for whole volume image

Setting for one slice image

talonchandler commented 2 years ago

I won't be able to look into this immediately, but I want to make sure I understand the issue. Can you help me understand the expected behavior?

Are you expecting the opposite? I'm guessing that when the "Use Full Volume" button is checked and you click "Create Overlay" you're expecting a 3D scrollable overlay. Then when you don't have the "Use Full Volume" button checked you're expecting just the user-selected "Slice" to be given an overlay.

This UI design is a bit confusing to me, too. Would it make sense to make the "Slice" input box disappear when "Use Full Volume" is checked?

JohannaRahm commented 2 years ago

You understood the issue correctly and the opposite was expected as you described!

The UI design handles the two options by deactivating the slice box when "Use Full Volume" is checked. If a slice value was inserted, it is deleted after checking the "Use Full Volume" box.

Now that I played around with the Display option again there is another unexpected behavior about the two Colormap options HSV & JCh. When switching from HSV to JCh the displayed color wheel is not updated. Switching it back to HSV updates the color wheel, which is now displaying the JCh colors although HSV is the chosen option. Independently from which colormap is chose, the HSV colormap is applied and I was not able to display the overlay with the JCh color map.

I agree that these issues are not that timely and it is fair to take a look at them at a later point.

image