Closed ziw-liu closed 6 months ago
I see you dropped the normalize option (which was set to True) by default but seems unused---any idea what this option was doing?
It rescales the output to unit mean. In all the places using it it's set to False
.
Introduced a new module
waveorder.correction
to replace thewaveorder.background_estimator
.inplane_oriented_thick_pol3d
model. The waverorder reconstructor is still using the old one. Maybe they should both be moved into awaveorder._deprecated
namespace?Consistency
The new method produces the same result:
Speed
Test on a large image:
NumPy (AMD EPYC 7302P CPU):
PyTorch implementation sees a 4x speed up on CPU:
An NVIDIA A40 GPU can provide 8x extra acceleration, or 35x faster compared to NumPy: