Closed talonchandler closed 3 months ago
One disadvantage of the .html file is that github doesn't render it, and there doesn't seem to be an easy way to open it in another tab. For comparison here's a saved .pdf of the .html file.
PTI_Experiment_Recon3D_anisotropic_target_small.pdf
GitHub doesn't render it because it's too large. But we can link to a third party one e.g. https://html-preview.github.io/?url=https://github.com/mehta-lab/waveorder/blob/a93fd512c6d66cb1b4bd8b983b288195cbb67fe5/examples/documentation/PTI_experiment/PTI_Experiment_Recon3D_anisotropic_target_small.html
@talonchandler @ziw-liu thanks! Are you using vscode's Jupyter extension for PDF export? Does it require TexLive in the backend?
I get the following PDF after running two cells. test.pdf
I will be able to do the proper review of the script tomorrow and can export a more complete PDF in the process. @ziw-liu's solution of rendering via https://html-preview.github.io/ also works. We can link the HTML in the README via that service.
Aha, thanks. I got jupyter nbconvert
(what vscode's convert uses) to run (I needed conda install pandoc
) and the pdf looks good. I think I prefer the pdf over the html, so I updated to the pdf.
Thanks Shalin:
P.S. I tested that all of the cells run...only thing that needs to change is the path to the data.
Thanks for the fixes! Merging and releasing now.
This PR moves the PTI spoke-pattern data example from a jupyter notebook to a script and a static .html file.
This PR also includes several suggestions from @mattersoflight to match the names to the most recent PTI submission:
black
to the notebook-style scriptSome other TODOs/questions: