mehtank / androminion

Androminion : Unofficial Dominion for Android
189 stars 65 forks source link

Mint/Quarry and Quick Play #16

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Enable Quick Play
2. Choose Big Actions
3. Use Mint when you have Quarry and Silver

What is the expected output? What do you see instead?

Quarry is automatically Minted.   Would like the option to choose Silver instead

What version of the product are you using? On what operating system?

1.9.b6.  CM7

Please provide any additional information below.

Original issue reported on code.google.com by zachcar...@gmail.com on 2 Oct 2011 at 2:09

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
Fixed in 1.9.b7

The fix is that it will not play automatically if you have Silver and Quarry in 
hand, but is there a better fix?

Original comment by fatmonkeysmile@gmail.com on 2 Oct 2011 at 3:23

GoogleCodeExporter commented 9 years ago
This might be another case where the player should just choose every time.  I 
started to say that it seems like Mint should automatically choose what to copy 
as long as the player only has Copper/Silver/Gold/Platinum, because each of 
those is strictly better than the ones that cost less.  Then I remembered that 
you might want more Copper if you have a Counting House.  I can also come up 
with some really contrived scenarios, like a time when you might not want to 
copy Gold because you know the next player has a Smuggler in hand.

I thought that maybe Mint could just copy the card that gives the most money, 
but there's no clean way to choose between, for example, Harem and Hoard.  
Also, would you necessarily want Contraband instead of either of those?  How 
would all of that work with Bank and Philosopher's Stone?  This just seems like 
a case where we have a lot of potential interactions and no clear algorithm for 
determining an optimal play.

With all of that said, this implementation would probably be best 99% of the 
time:
1) If the player has only Copper/Silver/Gold/Platinum, copy the one with the 
highest value.
2) If the player has any other treasures, require a player choice.

Original comment by August.D...@gmail.com on 26 Oct 2011 at 8:49

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
+1 to the comment from August.   I like the 99% implementation idea.

Original comment by zachcar...@gmail.com on 27 Oct 2011 at 8:13

GoogleCodeExporter commented 9 years ago
Fixed using 99% logic now (will be in 1.9.b7)

Original comment by fatmonkeysmile@gmail.com on 31 Oct 2011 at 6:19

GoogleCodeExporter commented 9 years ago
I just realized that I missed something obvious with my suggestion.  It 
should've been this:

1) If the player has exactly one type of treasure, copy it.
2) If the player has only Copper/Silver/Gold/Platinum, copy the one with the 
highest value.
3) If the player has any other treasures, require a player choice.

You may have already implemented it this way, but I thought I'd mention it just 
in case.

Original comment by August.D...@gmail.com on 2 Nov 2011 at 6:24

GoogleCodeExporter commented 9 years ago

Original comment by fatmonkeysmile@gmail.com on 2 Nov 2011 at 6:42

GoogleCodeExporter commented 9 years ago
Thanks, I didn't do that. Now fixed.

Original comment by fatmonkeysmile@gmail.com on 3 Nov 2011 at 1:11