search

mehtank / androminion

Androminion : Unofficial Dominion for Android
187 stars 64 forks source link

Adventures events are being included in games without that set. Ditto with Empires. #338

Open ayao44 opened 8 years ago

ayao44 commented 8 years ago

For example, playing a game with just Empires will have Ball (Adventures) as one of the Events. A game with just Adventures has yielded Tax (Empires) as one of the Events. It seems Summon (Promo event) can always be an option too if the game's randomizer gets them.

I don't believe this is necessarily a defect/bug as is, but would like to hear others' ideas about it. It doesn't seem like the rulebook says this is OK nor prohibited either....

On one hand, we already have the option to add Platinum/Colony and Shelters to games without Prosperity and Dark Ages respectively (which was something I put in a request for). Here, it's not like the Events need to be tied to their own set, as the app will always have access to those "components" (e.g. the game just puts Debt tokens as appropriate even if Empires wasn't selected in the randomizer).

OTOH, I don't know if there's really a strong interest to "compartmentalize" the Events to their own sets, and allowing them only if their sets/expansions are enabled.

dominionator commented 8 years ago

Currently the Events are being selected from a unified pool of all Event cards. I'm going to not call this a defect outright. The UI clearly states that the expansions you select to randomize from are for selecting Kingdom cards (not Events). However, it does beg the question if there is some utility in being able to limit the pool of Events to the ones from a particular expansion (or set of expansions). Currently there are only the three expansions with Events (20 from Adventures, 13 from Empires, and the Summon Promo). I'd like to hear if you have any more thoughts on the matter.

ayao44 commented 8 years ago

Put more thought into this... my suggestion would be to implement something similar to what we have already have with the sets in general... allow picking which sets we want Events from.

Allocating a block/section like with the Kingdom card sets would take up more space on the menu, but would allow for high flexibility, not to mention set things up in case new Event cards are introduced.

Having a dropdown menu to select which set would save space, at the cost of being a bit more cumbersome. So have the following options at minimum... Adventures (only), Empires (only), all. Adding Summon shouldn't make things too cluttered, but at least to me, the major choices would be between Adv. and Empires.