search

mehtank / androminion

Androminion : Unofficial Dominion for Android
185 stars 64 forks source link

Missing Empire Images #374

Open EldRoos opened 7 years ago

EldRoos commented 7 years ago

http://dominion.diehrstraits.com/

We use this superb site to download and show images. But it has not been updated 1.5 years. Do anyone know where to find images for: Empires, the Second Editions and new promo cards?

Alternatively scan these images yourself - or extract them from official pdf files. Note images should ideally be in be in 296x473 resolution (or 473x296 for events/landmarks) as Mark have on his site. Higher res would be cool but that would both make the game larger, take longer time to download and make it a greater target for cease and desist. Less resolution would be just ugly - it is small already. But my new image scaling function should be able to handle any image resolution.

Can anyone speak to Mark Diehr to check if he can find more cards (or send him yours) to update the side?

Also, this is only for english. If anyone knows about images for other languages - please tell.

schoeggu commented 7 years ago

High res scans are on the ds wiki http://wiki.dominionstrategy.com/index.php/Empires

EldRoos commented 7 years ago

Yes I know. They are too big, and there is no easy way to link to the right image from there as the url is somewhat random. I'm collecting images myself and might release a pack.

schoeggu commented 7 years ago

Probably the best way would be to have a button in the settings to download a package of all images at once. You could add a button for standard size and one for high res. That way the apk keeps lightweight.

EldRoos commented 7 years ago

Yes but as I said in chat and here #375, I have not found a way to download files from newest android yet.

torgoton commented 7 years ago

Card images should not be included in the apk. Maybe you could check for a file existing in the user's google drive and process that.

On Mon, Oct 3, 2016 at 10:20 AM, EldRoos notifications@github.com wrote:

Yes but as I said in chat and here #375 https://github.com/mehtank/androminion/issues/375, I have not found a way to download files from newest android yet.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/mehtank/androminion/issues/374#issuecomment-251135844, or mute the thread https://github.com/notifications/unsubscribe-auth/AACSMwnA5TbiD9d8CVn4NZH_8Upqmwnsks5qwR1PgaJpZM4KMD_A .

EldRoos commented 7 years ago

This can be closed as I made a pack.

dominionator commented 7 years ago

This issue should probably remain open until we find a better (automated) solution for loading card images. Or we close this and open an new issue for the problem. I think this should be one of the following unless someone has a better idea: 1) Get Mark to update his site with the new images in the correct places 2) Find a new place hosting appropriately sized and named images that is ok with us downloading their images periodically and that will be around for a good long time. Images for multiple languages would be awesome.

EldRoos commented 7 years ago

I think that downloading one image one at a time is a bad idea. Will take long time, and the device would be filled with downloaded notifications.

We should use the image pack I made - because it have superior quality. I will make a smaller version too later on. And it should be installed/unizpped by the app. But you are right it should not be hosted here. I will find some place to upload it too. Any ideas?

schoeggu commented 7 years ago

I too prefer to download all images at once. But I'd leave the functionality to download missing images in. That way it will automatically download an image if it is deleted accidentally. You could add a button in the settings to download the package "Download all card images now".

I'll scan one of my cards to see if the quality of my scanner is good enough. If there is an quick and easy way to convert all the scans to correctly sized png images I may scann all of the German cards. Edit: Scans of German cards are already on the dominion strategy wiki. But only up to Hinterlands.

EldRoos commented 7 years ago

Good luck with that. I recommend you scan in high resolution first, then you can resize them afterwards (made a script in Photoshop that automatically make some alterations). Dominionstrategy uses resolution of 1236x1992 - don't know the dpi of that but you will soon find out :). Maybe 600.