mehtank / androminion

Androminion : Unofficial Dominion for Android
189 stars 65 forks source link

pls let me know which files needs for translation #524

Open yunejae opened 6 years ago

yunejae commented 6 years ago

Hi. Im fan of Dominion and androminion

always thanks for ur contribution

As I'm a Korean. I want to translate strings as Korean.

I read source code for Androminion, I think strings-cards, ui, themes, etc needs to be translated, as other language contained in [Values-de, fr]

I would appreciate if you advice me list of files to be translated, and also where to upload.

will sincerly wait for your comment. thank you.

dominionator commented 6 years ago

You are correct in assuming the files that are in the other translation folders need to be translated (translate from the English files in androminion/res/values, use existing translations for other languages as guides if needed). These include:

You can either make a pull request with the added changes if that is something you are comfortable with or you can put the translated files in a zip file (or other archive file) and attach them in a reply in this issue and I will incorporate the translations.

Generally, we recommend you use existing published translated names of cards when possible. This may not work if the existing translated names conflict with newer cards, so feel free to change them to the most appropriate name that fits. I'm not sure any expansion past Seaside got published in Korean.

If you have any questions about how any of the keys in the translation files work or what they mean, please reply here. Just be aware that I have essentially zero knowledge of Korean, so I won't be able to check your work for accuracy or consistency. You can always make edits later if you find any mistakes. Also, try and keep the keys in the same order as the original English files when translating. It helps when cross-checking files for certain refactorings.

Thanks for your willingness to help!