search

mei28 / luminate.nvim

🌟 Highlight yanked, pasted, and undone/redone text in Neovim with a splash of color.
MIT License
39 stars 2 forks source link

fix #5 #6

Closed mei28 closed 3 months ago

mei28 commented 3 months ago

Hi, @shauryagoel

I have fixed the bugs (#5 ) in the fix#5 branch. Could you please check if the fixes work as expected? If you are using lazy.nvim, you can test it by setting the branch as follows:

{
  'mei28/luminate.nvim',
  branch = "fix#5",
  ...
},

If everything works well, I will merge it into the main branch. Thank you!

close #5

shauryagoel commented 3 months ago

Thanks for the update. This fixes the issue described in #5. However, after some testing, I found 2 issues- 1) Opening a new buffer and pasting some text from the system clipboard does not highlight the pasted text. However, on pasting again the new text gets highlighted. This issue of not highlighting appears when pasting in a new buffer for the first time only. 2) If in the following Python snippet with some indented code-

def func():
    a = 2|

| is the cursor position in normal mode. If I press o to get a newline below the current line, Nothing gets highlighted the first time (as it should be). However, repeating the operation highlights the indented spaces in the newline everytime onwards.

mei28 commented 3 months ago

Thank you for checking!

It seems there is no issue with bug #5, so I would like to merge this PR.

I am aware of the two new issues you pointed out, including the case where indentation is highlighted when breaking lines with 'o'. I have been trying to fix it, but I haven't succeeded yet :'(

Could you please report these issues separately as two new issues?