search

meichthys / foss_photo_libraries

Free and Open Source Photo Libraries
https://meichthys.github.io/foss_photo_libraries/
MIT License
1.7k stars 45 forks source link

Add encryption for data at storage #68

Open 1Euro7Cent opened 8 months ago

1Euro7Cent commented 8 months ago

See details/reasons here https://github.com/immich-app/immich/issues/450 this is a relative important feature for me. But I need to figure it out by the "hard way"

ildyria commented 7 months ago

I don't think that is something a photo gallery should concern about:

https://stackoverflow.com/a/3938083

You cannot, however, remove the need for the user to trust the server because the server can send whatever JavaScript code it wants to to the client, which can send a copy of the image to anyone when it is decrypted.

The explanations of https://github.com/immich-app/immich/issues/450 also makes quite good sense.

BlackLotus commented 2 months ago

Since Android Client, Desktop Client and so on are options in this repo this should be added. (not javascript code that can be modified by a rogue admin) If the encryption is handled clientside and is implemented well it can be done. Ente #76 for instance encrypts everything by default (using PGP). It supports everything mentioned here

There is no way to implement "e2ee" in a solution like immich. If you want e2ee in a media storage, put your photos in an encrypted zip file and put it on an SFTP server. You can't have galleries, browsing, metadata with e2ee

and the comment is only true, because immich was build not with privacy in mind (which is ok), but there certainly are solutions that offer all that and more and feature e2ee.

Nextcloud and Ente were designed with privacy first in mind and so support encryption by default.

Edit: ente has it's implementation split into data server (museum) and clients (web, android, desktop, ...) so you could host the web frontend yourself as well without having to trust the admin. I'm not affiliated with ente, I just host it myself