search

meichthys / uptime_kuma

Uptime Kuma HACS integration
110 stars 23 forks source link

Request to be merged into Home-Assistant Core #11

Open meichthys opened 2 years ago

meichthys commented 2 years ago

@m1ckyb Would you be willing to help get this merged into core?

m1ckyb commented 2 years ago

I'm not really that good at that, can try and help..

meichthys commented 2 years ago

Oops, i mean't to tag @jayakornk, but feel free to help out where you can 👍

pixelrazor commented 1 year ago

Is there any sort of summary of what needs to be done to get this added to core?

meichthys commented 1 year ago

It needs to be submitted and reviewed. From my experience it's not a pleasant experience since they generally don't allow pull requests with multiple types of sensors, so you'd have to strip mich of the functionality out and then add it back in separate smaller pull requests. They will want tests which can sometimes be ignored. Lots of code changes will be recommended prior to merging. It's a good process to ensure high quality code, but not one I'm wanting to go through again. Any help would be appreciated!

pixelrazor commented 1 year ago

I think we should switch to that socket API library before that, since it'll be a change in config (user/pass vs key). That or wait for rest API support

meichthys commented 1 year ago

I have no intentions of trying to merge this myself, but I'd be glad to let someone to take the reigns on this 👍