fix: swap the 'open' command for 'python -m webbrowser'

meiji163 / gh-notify

GitHub CLI extension to display GitHub notifications

The Unlicense

209 stars 21 forks source link

Closed LangLangBart closed 1 year ago

LangLangBart commented 1 year ago

intended to fix #55
open works only reliably under macOS, a cross-platform solution could be python -m webbrowser

[ ] shall python be checked for existence
- on Linux and macOS, Python is usually included by default
- windows ?
[ ] discuss any ideas for a better solution to the issue?

rEnr3n commented 1 year ago

python is not installed by default on arch linux.

LangLangBart commented 1 year ago

OK, I will leave the current solution using 'python' and wait to see if any feedback comes.

Alternatively, a switch to something similar to this could also work:

  case "$(uname -s)" in
    Darwin) open "$url"     ;;
    Linux)  xdg-open "$url" ;;
    *)      start "$url" ;;
  esac