meiji163 / gh-notify

GitHub CLI extension to display GitHub notifications
The Unlicense
209 stars 21 forks source link

Mark done #91

Open sitano opened 3 months ago

sitano commented 3 months ago

Allow the user to select and delete/done notifications with ctrl-x. I changed individual Done to ctrl-x and comment to ctrl-c. Not sure about what are good keys for that. in continuation of https://github.com/meiji163/gh-notify/pull/90.

LangLangBart commented 3 months ago

rebased

LangLangBart commented 3 months ago

Comment to ctrl-c.

⌃ Control + C is typically used for canceling. Set it to ⌃ Control + O for now.

Done to ctrl-x

Okay.


The issue is that there is no done field, as mentioned in the referenced issue. Therefore, I won't merge it for now unless GitHub adds this feature or @meiji163 also desires this feature.

sitano commented 3 months ago

@LangLangBart I see your point. Responded in https://github.com/meiji163/gh-notify/issues/47#issuecomment-2245307507.