meilisearch / charabia

Library used by Meilisearch to tokenize queries and documents
MIT License
248 stars 86 forks source link

Fix `update-kvariants` CI #256

Closed choznerol closed 8 months ago

choznerol commented 8 months ago

Pull Request

Related issue

Fixes #254

What does this PR do?

Fix the failing CI job update-kvariants

According to a failed job update-kvariants#7445878735:

Run ./kvariants/bin/sync_dictionaries.sh
/home/runner/work/_temp/23998b39-752b-4208-8978-233c8a1d6bc9.sh: line 1: ./kvariants/bin/sync_dictionaries.sh: No such file or directory
Error: Process completed with exit code 127.

It's just that the script was renamed during https://github.com/meilisearch/charabia/commit/49ee6919acf7ec676ed79394ac134ee2f533234a#diff-2a8d55e3eb61740bcff85b34a600a97afdc4c49f543e40fe04c5d22a3ff9fc65

also did a simple test of the script locally ![image](https://github.com/meilisearch/charabia/assets/12410942/b2f609b7-1dbf-45a2-b5f7-879130deeaca)

PR checklist

Please check if your PR fulfills the following requirements:

Thank you so much for contributing to Meilisearch!

ManyTheFish commented 8 months ago

Nice! Thank you for taking the time to investigate @choznerol. I'm happy to see you in our contributor this year too, Happy new year,

bors merge

choznerol commented 7 months ago

Thanks! Happy new year to you too 😄